[refactor] nix-environment #955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! If you happen to know how to test this easily in the CI I would greatly appreciate otherwise i'll just merge it as is |
I have added a workflow for that. Now there are 2 versions you can build via the nix flake.
|
muellerbernd
force-pushed
the
improve-nix-environment
branch
2 times, most recently
from
e3e1ebb to
4893c43
Compare
|
I have done a rebase with the main branch but I still need to update the Cargo.lock, because for the nix build Sources are not allowed to be defined multiple times. See error message: > Running phase: unpackPhase
┃ > unpacking source archive /nix/store/6r3p4c0c90sfv69mdmz1zzxvkd9s1ryk-source
┃ > source root is source
┃ > Executing cargoSetupPostUnpackHook
┃ > Finished cargoSetupPostUnpackHook
┃ > Running phase: patchPhase
┃ > Executing cargoSetupPostPatchHook
┃ > Validating consistency between /build/source/Cargo.lock and /build/cargo-vendor-dir…
┃ > Finished cargoSetupPostPatchHook
┃ > Running phase: updateAutotoolsGnuConfigScriptsPhase
┃ > Running phase: configurePhase
┃ > Running phase: buildPhase
┃ > error: source `git+https://github.com/EricLBuehler/mistral.rs.git#8069f9072500398da…
┃ > note: Sources are not allowed to be defined multiple times.
┃ For full logs, run 'nix log /nix/store/hr5q0zkgdnlys05assi8wyk37cxw6xf1-latest.drv'. |
muellerbernd
force-pushed
the
improve-nix-environment
branch
from
7eeb4c4 to
813221d
Compare
…release (latest release)
muellerbernd
force-pushed
the
improve-nix-environment
branch
from
bda9c84 to
bfe832f
Compare
|
@haixuanTao can this be merged? If not, give me a hint on what's missing to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test dora on my NixOS machine and needed to refactor the nix files. With the provided dev-shell in the flake it was also possible to run the python example from the getting started.
After this PR is merged it would also be possible to get a working dora dev-shell via nix by calling the following command: