Skip to content

fix: allow move-up monitor transition with optional legacy maximize behavior#533

Open
martinmarth wants to merge 2 commits intodomferr:mainfrom
martinmarth:fix/up-monitor-transition-setting
Open

fix: allow move-up monitor transition with optional legacy maximize behavior#533
martinmarth wants to merge 2 commits intodomferr:mainfrom
martinmarth:fix/up-monitor-transition-setting

Conversation

@martinmarth
Copy link
Copy Markdown

Summary

This PR fixes an issue where Move Window Up could not move windows to a monitor above when monitors are stacked vertically.

To preserve backward compatibility, it also introduces a setting that keeps the legacy behavior by default.

What was happening

In the keyboard move flow, UP could be consumed by local maximize logic before monitor-transition fallback was reached.
Result: DOWN worked, but UP often did not move the window to the monitor above.

Changes

  • Added new setting key: always-maximize-with-up (default: true)
  • Wired setting in Settings (KEY, getter, setter)
  • Updated UP handling in tiling move logic:
    • maximize on UP only when:
      • always-maximize-with-up is enabled, or
      • there is no monitor in that direction (clamp)
  • Added Preferences toggle:
    • Always maximize with Move Up

Behavior after change

  • Default (unchanged): Move Up maximizes on current monitor.
  • Optional: when the setting is disabled, Move Up transitions to monitor above (if available).
  • Fallback: if no monitor exists above, Move Up still maximizes.

Files changed

  • resources/schemas/org.gnome.shell.extensions.tilingshell.gschema.xml
  • src/settings/settings.ts
  • src/components/tilingsystem/tilingManager.ts
  • src/prefs.ts

Testing

  1. Arrange monitors vertically.
  2. Keep setting enabled (default): verify Move Up maximizes.
  3. Disable setting in Preferences: verify Move Up moves to monitor above.
  4. Verify fallback: with no upper monitor, Move Up maximizes.

Closes #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Window Up shortcut does not switch to monitor above in vertically stacked monitor layouts

1 participant