fix: allow move-up monitor transition with optional legacy maximize behavior#533
Open
martinmarth wants to merge 2 commits intodomferr:mainfrom
Open
fix: allow move-up monitor transition with optional legacy maximize behavior#533martinmarth wants to merge 2 commits intodomferr:mainfrom
martinmarth wants to merge 2 commits intodomferr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
Move Window Upcould not move windows to a monitor above when monitors are stacked vertically.To preserve backward compatibility, it also introduces a setting that keeps the legacy behavior by default.
What was happening
In the keyboard move flow,
UPcould be consumed by local maximize logic before monitor-transition fallback was reached.Result:
DOWNworked, butUPoften did not move the window to the monitor above.Changes
always-maximize-with-up(default:true)Settings(KEY, getter, setter)UPhandling in tiling move logic:UPonly when:always-maximize-with-upis enabled, orclamp)Behavior after change
Move Upmaximizes on current monitor.Move Uptransitions to monitor above (if available).Move Upstill maximizes.Files changed
resources/schemas/org.gnome.shell.extensions.tilingshell.gschema.xmlsrc/settings/settings.tssrc/components/tilingsystem/tilingManager.tssrc/prefs.tsTesting
Move Upmaximizes.Move Upmoves to monitor above.Move Upmaximizes.Closes #532