fix(sandbox): allow read access to /sys for interface stats under Landlock#370
Merged
Conversation
…dlock
The Landlock ruleset handles all filesystem reads but only added read
allow-rules for /proc and the GeoIP read_paths. The interface-stats
poller enumerates interfaces via read_dir("/sys/class/net") and reads
each /sys/class/net/<iface>/statistics/* counter, which got denied with
EACCES once the sandbox was enforced. The error was swallowed at debug
level, so the Interfaces panel silently showed "No interface stats
available" (independent of -i any vs auto-detected interface).
Add read-only allow-rules for /sys/class/net (enumeration) and
/sys/devices (the per-interface statistics entries are symlinks into
/sys/devices and Landlock evaluates the resolved path). Sandbox stays
fully enforced; this only grants read.
Also surface the stats-collection failure once at warn! instead of a
silent debug!, so a future sandbox/permission regression is visible at
the default log level.
Verified in OrbStack (Landlock ABI 7, FullyEnforced): without the rule
read_dir("/sys/class/net") fails with EACCES; with it all interfaces are
readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Landlock ruleset handles all filesystem reads but only added read allow-rules for /proc and the GeoIP read_paths. The interface-stats poller enumerates interfaces via read_dir("/sys/class/net") and reads each /sys/class/net//statistics/* counter, which got denied with EACCES once the sandbox was enforced. The error was swallowed at debug level, so the Interfaces panel silently showed "No interface stats available" (independent of -i any vs auto-detected interface).
Add read-only allow-rules for /sys/class/net (enumeration) and /sys/devices (the per-interface statistics entries are symlinks into /sys/devices and Landlock evaluates the resolved path). Sandbox stays fully enforced; this only grants read.
Also surface the stats-collection failure once at warn! instead of a silent debug!, so a future sandbox/permission regression is visible at the default log level.
Verified in OrbStack (Landlock ABI 7, FullyEnforced): without the rule read_dir("/sys/class/net") fails with EACCES; with it all interfaces are readable.