Skip to content

feat: handle if-none-match header and also send etag to client #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mccare wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: handle if-none-match header and also send etag to client #15

mccare wants to merge 1 commit into from

Conversation

@mccare
Copy link

@mccare mccare commented Dec 11, 2022 •
edited
Loading

This will add etag support to GET requests.

  • send the etag along in the response headers
  • test for "if-none-match" header and compare the values to the etag from GCS.

I'm a go newbie, so feel free to correct or ask for corrections where something doesn't fit in the schema.

@mccare mccare force-pushed the handle-etag branch 3 times, most recently from b9b9d2c to 343472a Compare December 11, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mccare