Skip to content

TMario scaffolding pt 1#77

Merged
Mrkol merged 1 commit intodoldecomp:mainfrom
Cuyler36:tmario_scaffolding_1
Feb 6, 2026
Merged

TMario scaffolding pt 1#77
Mrkol merged 1 commit intodoldecomp:mainfrom
Cuyler36:tmario_scaffolding_1

Conversation

@Cuyler36
Copy link
Contributor

@Cuyler36 Cuyler36 commented Feb 6, 2026

Decent amount of work scaffolding TMario actor class members. Still needs work. Gave variable names based on usage unless they're unused or low ref count. In those cases I left them as unknown.

@decomp-dev
Copy link

decomp-dev bot commented Feb 6, 2026

Report for GMSJ01 (bba67ab - 6306acc)

📈 Matched code: 26.18% (+0.01%, +392 bytes)
📈 Matched data: 27.93% (+0.02%, +120 bytes)

✅ 2 new matches
Unit Item Bytes Before After
mario/Player/MarioAutodemo TMario::electricDamage() +132 66.36% 100.00%
mario/Player/MarioAutodemo .sdata2 +13 89.66% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
mario/Player/MarioInit TMario::~TMario() +56 66.04% 92.45%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
mario/Player/MarioInit TMario::TMario() -4 77.95% 77.93%

@Cuyler36 Cuyler36 force-pushed the tmario_scaffolding_1 branch from e5f124e to 25265e8 Compare February 6, 2026 12:52
@Cuyler36 Cuyler36 marked this pull request as ready for review February 6, 2026 13:03
@Cuyler36 Cuyler36 force-pushed the tmario_scaffolding_1 branch from 25265e8 to 407c9ed Compare February 6, 2026 14:43
@Cuyler36 Cuyler36 force-pushed the tmario_scaffolding_1 branch from 407c9ed to 6306acc Compare February 6, 2026 21:48
@Mrkol Mrkol merged commit 7404ebc into doldecomp:main Feb 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants