MarioAutodemo.cpp mostly matching#76
Merged
Mrkol merged 10 commits intodoldecomp:mainfrom Feb 6, 2026
Merged
Conversation
Report for GMSJ01 (684f416 - 44be2ab)📈 Matched code: 26.17% (+0.04%, +1448 bytes) ✅ 7 new matches
📈 13 improvements in unmatched items
|
Mrkol
requested changes
Feb 6, 2026
src/Player/MarioAutodemo.cpp
Outdated
| } | ||
| TModelGate* gate = (TModelGate*)mHolder; | ||
| u16 gateUnk72 = gate->unk72; | ||
| Mtx* nodeMatrices = gate->unk78->getModel()->mNodeMatrices; |
Collaborator
There was a problem hiding this comment.
ghidra is lying, you can just do MtxPtr mtx = gate->unk78->getModel()->getAnmMtx(gateUnk72); and use it below and it'll still match
Contributor
Author
There was a problem hiding this comment.
Ghidra tends to do that 😅 I should really get better at checking for existing better functions :) Thanks for the heads up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the s16 implementation for set for TVec from TP since i couldn't make it match properly. I couldn't see the existing one being used anywhere, so i kept the old implementation as a comment until the PR.
If the existing one has been validated, then i will revert the copy and let the unmatching stuff be until we have more examples. Otherwise i will remove the old implementation for it.