Draft
Conversation
Replace goto-based spaghetti with mnDiagram_GetNextNameIndex helper in name mode right arrow section. Simpler, more readable code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add docstring for mnDiagram_802417D0 explaining directional arrow logic - Fix swapped comments: jobjs[4] is Up arrow, jobjs[5] is Left arrow - Clarify cursor_pos encoding is (col << 8 | row) for scroll offset - Update mnDiagram_UpdateScrollArrowVisibility docstring with jobj mappings - Fix types.h comments for fighter_cursor_pos and name_cursor_pos Validated via runtime debugging with Dolphin memory inspection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Rename address-based functions to descriptive names based on code analysis: Initialization: - mnDiagram_802437E8 → mnDiagram_Init (entry point, loads DAT) - mnDiagram_80243434 → mnDiagram_Setup (creates main GObj) - mnDiagram_8023FA6C → mnDiagram_SortFightersByKOs - mnDiagram_8023FC28 → mnDiagram_SortNamesByKOs Grid display: - mnDiagram_80241730 → mnDiagram_UpdateGridDisplay (orchestrates refresh) - mnDiagram_80241668 → mnDiagram_ClearGridContent - mnDiagram_8024227C → mnDiagram_DrawGridCells - mnDiagram_80241E78 → mnDiagram_DrawCellNumber Headers: - mnDiagram_802427B4 → mnDiagram_DrawNameHeaders - mnDiagram_80242C0C → mnDiagram_DrawFighterHeaders - mnDiagram_80242B38 → mnDiagram_CreateFighterIcon Navigation: - mnDiagram_802417D0 → mnDiagram_UpdateScrollArrows - mnDiagram_802433AC → mnDiagram_CreateCursor Popup: - mnDiagram_80241310 → mnDiagram_CreatePopup - mnDiagram_80240D94 → mnDiagram_PopupSetupText Also adds docstrings with @brief/@param documentation and renames parameters from generic arg0/arg1/arg2 to descriptive names. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add u8 variant of CheckAllZeroPlayTime inline to handle different codegen requirements when parameter type is u8 vs int. The u8 version requires the `int i = 0; int offset = i;` pattern to force correct register allocation order. Also simplified the int version of CheckAllZeroPlayTime by removing the unused offset variable (was a fakematch). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Rewrote the input processing function for VS Records diagram menu. Handles A button (popup), B button (exit), L/R (screen switch), toggle mode, and D-pad navigation for both fighter and name modes. Remaining differences are register allocation (8 vs 9 callee-saved). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix sign extension: use u32 for result instead of int - Remove unused variables (var_r6) - Simplify mode toggle using ternary expression - Add PAD_STACK(40) for correct stack frame size Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Report for GALE01 (ec603e3 - 0876f9e)📈 Matched code: 50.91% (+0.01%, +560 bytes) ✅ 5 new matches
💔 4 broken matches
📈 9 improvements in unmatched functions
📉 11 regressions in unmatched functions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still WIP
some more matches + documentation in mndiagram & mndiagram2. start matching mndiagram3 as well