Avoid triggering a deprecation notice in doctrine/collections #12238
+131
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg0ire Please advise: Should I bump requirements for doctrine/collections in composer.json here? I guess I cannot, since we're still compatible with |
mpdude
force-pushed
the
fix-collections-deprecation
branch
2 times, most recently
from
60148e0 to
0060f4d
Compare
This updates the code to avoid triggering the deprecation introduced in doctrine/collections#472.
mpdude
force-pushed
the
fix-collections-deprecation
branch
from
0060f4d to
1865717
Compare
|
That's right, you shouldn't. Not in a patch release anyway. |
|
Found doctrine/doctrine-website#485. I knew we discussed that before. So, how to make PHPStan happy when I cannot tell for sure if checking against doctrine/collections >= 2.4.0 or below that? |
|
What do you mean? The CI job is installing |
greg0ire
reviewed
Oct 27, 2025
mpdude
force-pushed
the
fix-collections-deprecation
branch
from
f87e380 to
da67f32
Compare
greg0ire
approved these changes
Oct 27, 2025
greg0ire
approved these changes
Oct 27, 2025
|
Thanks @mpdude ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code to avoid triggering the deprecation introduced in doctrine/collections#472.
Closes #12237.