make etcd periodic member sync configurable and optional#138
Closed
vikstrous wants to merge 1 commit intodocker:masterfrom
Closed
make etcd periodic member sync configurable and optional#138vikstrous wants to merge 1 commit intodocker:masterfrom
vikstrous wants to merge 1 commit intodocker:masterfrom
Conversation
vikstrous
force-pushed
the
fix-137
branch
2 times, most recently
from
5cb66c9 to
a742cad
Compare
Author
|
I don't understand this test failure. Is golint master broken? |
Contributor
|
Hey @vikstrous, I no longer maintain the library but rebasing on master should do the trick. /cc @sanimej for review and merge |
|
@vikstrous are you planning on fixing the build? |
Author
|
I don't think I broke it. The failure seems unrelated. Edit: Ohhh I see now that options needs to be nil checked every time... Yeah I guess I can fix that. |
fix docker#137 Signed-off-by: Viktor Stanchev <me@viktorstanchev.com>
Contributor
|
@vikstrous Someone needs to merge #154 first and then you can rebase on top of it to fix the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #137