Skip to content

Handle errorDetails and raise exception on failure instead of Str Stream #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Handle errorDetails and raise exception on failure instead of Str Stream #3321

wants to merge 2 commits into from

Conversation

Khushiyant
Copy link
Contributor

Closes #3161

This aims to eliminate silent failures in image push while using client.images.push

Adds the following:

  • Error raising in stream handling via errorDetails
  • Tests with error raise asserts

Engine API doesn't raise error but return JSON with errorDetail and progressDetail [See here]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

client.images.push doesnt raise exception

1 participant

@Khushiyant