Open
Conversation
Track hovered URL span in the messages component and apply underline styling during rendering. Switch mouse mode from CellMotion to AllMotion so hover events fire without a button held. Assisted-By: docker-agent
Contributor
|
didn't this have other side-effects in the past? also i'm not sure if it's the most reliable solution across terminals, i'll give it a test on some that I've notice being problematic |
Contributor
|
On macOS, it's all good using Maybe it was windows that had issues with the If we could get a test at least on Windows Terminal that'd be great, I won't have access to one until Monday at the best.. Maybe the issue I remember had gotten fixed in the upstream charm libs as well |
Member
Author
|
@simonferquel could you give it a try? |
Contributor
|
What is the test case? |
trungutt
approved these changes
Apr 7, 2026
Member
Author
|
@simonferquel Ask the agent to print the url of google. Make sure it's underlined and clickable when you move the mouse over it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track hovered URL span in the messages component and apply underline styling during rendering. Switch mouse mode from CellMotion to AllMotion so hover events fire without a button held.
Assisted-By: docker-agent