Add colouration via Click#27
Open
trombonehero wants to merge 3 commits into
Open
Conversation
Reduce duplication of logic between this script and the icalendar package.
This simplifies some I/O handling, but more importantly, it sets us up to do fancier output (e.g., colour).
dmedvinsky
reviewed
Feb 13, 2026
dmedvinsky
left a comment
dmedvinsky
left a comment
Owner
There was a problem hiding this comment.
Hey! Thanks for the contribution. Frankly, I haven't been using this for a long time, and I don't really mind a basically complete rewrite. But looking at the code, I have a couple of questions.
Comment on lines
-107
to
-112
| max_width = max(len(k) for k, v in vals) | ||
| for k, v in vals: | ||
| pad = u' ' * (max_width + 1 - len(k)) | ||
| line = u'%s:%s%s' % (k, pad, v) | ||
| res.append(line) | ||
| return u'\n'.join(res) |
Owner
There was a problem hiding this comment.
There used to be a pretty table-like padding here. Can this be kept intact?
|
|
||
|
|
||
| @click.command() | ||
| @click.argument("ics_file", type=click.File('r', encoding='utf-8'), default='-') |
Owner
There was a problem hiding this comment.
Haven't used click for years... This preserves the old filename/stdin behaviour, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.