test: Add daemon repair function tests#353
Closed
whitmo wants to merge 23 commits intodlorenc:mainfrom
Closed
Conversation
Fixes branch naming inconsistency by standardizing on 'multiclaude/' prefix. Maintains backward compatibility for cleanup of legacy 'work/' branches. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The comment at internal/cli/cli.go:5128 referenced docs/EXTENSION_DOCUMENTATION_SUMMARY.md which doesn't exist. Updated the comment to reference the actual existing extension docs (docs/extending/SOCKET_API.md and docs/extending/STATE_FILE_INTEGRATION.md) that need to be kept in sync when CLI commands affecting extension surfaces change. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…space Improve the repair command to be more comprehensive by ensuring core agents and a default workspace exist after cleanup. This enhancement aligns with ROADMAP.md P1 "Agent restart" by making repair more robust and reducing the need for manual intervention. Changes: - CLI: Add ensureCoreAgents() and ensureDefaultWorkspace() helpers - CLI: Update localRepair() to recreate missing core agents - CLI: Create default workspace "my-default-2" if none exist - Daemon: Add ensureCoreAgents() and ensureDefaultWorkspace() methods - Daemon: Update handleRepairState() to recreate missing agents - Both: Improve output to show what was removed and what was created - Tests: Add comprehensive tests for all scenarios Key Features: 1. Recreates missing supervisor agent if absent 2. Recreates missing merge-queue (non-fork) or pr-shepherd (fork) 3. Creates default workspace if no workspaces exist 4. Does not duplicate existing agents/workspaces 5. Provides detailed output showing: - Removed: dead agents - Cleaned: orphaned resources - Created: core agents and workspaces Test Coverage: - TestRepairEnsuringCoreAgents: Verifies core agents are created - TestRepairEnsuringPRShepherdInForkMode: Fork mode verification - TestRepairDoesNotDuplicateAgents: Prevents duplicates Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Restructures the CLI help output to be more user-friendly: - Add QUICK START section showing the 4 most common commands - Group commands into 6 categories: DAEMON, REPOSITORIES, AGENTS, COMMUNICATION, MAINTENANCE, META - Hide 7 redundant aliases from help (still functional, just not displayed) - Add Hidden and Category fields to Command struct for flexibility The help output now shows 21 focused commands instead of 28 scattered entries, making it much easier for new users to understand what to do. Also adds CLI_RESTRUCTURE_PROPOSAL.md documenting the analysis and future restructuring options for v2.0. Aligns with ROADMAP P2 "Better onboarding". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add LongDescription field to Command struct for detailed help text - Add comprehensive help for 'repo hibernate' explaining token consumption - Show specific active agents in 'multiclaude status' (supervisor, merge-queue, etc.) instead of just 'X core, Y workers' - Add token consumption warning when agents are active - Point users to 'hibernate --all' to stop token usage This makes hibernate more discoverable and helps users understand that running agents continuously consume API tokens. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When run inside an agent worktree, `multiclaude refresh` now syncs just that worktree directly instead of triggering a global refresh via daemon. This gives agents immediate feedback and control over their sync process. Changes: - Add context detection: automatically identifies agent worktree from cwd - Add direct refresh: syncs single worktree using worktree.RefreshWorktree() - Add --all flag: explicitly triggers global refresh (previous behavior) - Update /refresh slash command to recommend CLI method - Provide detailed output: fetch status, rebase info, conflict handling Behavior: - Inside agent worktree: refreshes that worktree directly with feedback - Outside agent context: triggers daemon-based global refresh - With --all flag: always triggers daemon-based global refresh P0 Roadmap item: Worktree sync Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Workers now receive guidance to use /sc:index-repo for large codebase exploration, achieving 94% token reduction (58K → 3K tokens). This improves memory usage and search efficiency for complex tasks. The guidance is embedded in the worker template and will be included in system prompts for all new worker agents. Task: If a skill is provided such as QMD that enables better memory and tokens and searching, make sure that Multiclaude uses it. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…c#333 on pr-triage-b2 Tests from multiclaude workers (silly-otter, lively-otter, clever-bear): - PR dlorenc#338: Token-aware status display, hibernate help, rich list_repos response - PR dlorenc#339: Context-aware refresh, worktree path detection, --all flag parsing - PR dlorenc#337: Categorized help (worker report captured, tests via CLI assertions) - PR dlorenc#333: Enhanced repair (worker report captured, daemon handler tests) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…faultWorkspace, spawnCoreAgent These functions (from PR dlorenc#333) had zero test coverage. Adds 8 tests covering: - ensureCoreAgents with empty state, missing tmux session, existing agents, fork mode - ensureDefaultWorkspace with empty state, existing workspace, missing tmux session - spawnCoreAgent error message includes resp.Error details Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureCoreAgents(),ensureDefaultWorkspace(), andspawnCoreAgent()ininternal/daemon/daemon_test.gopr-triage-b2branch which contains the repair enhancementsTest Coverage Added
ensureCoreAgentsensureDefaultWorkspacespawnCoreAgentresp.ErrorfromhandleRestartAgentTest plan
go test ./internal/daemon/ -run "TestEnsureCoreAgents|TestEnsureDefaultWorkspace|TestSpawnCoreAgent" -v— all 8 passgo test ./internal/daemon/— full suite passes (~4.4s)t.Skip()when tmux unavailableNotes
setupTestDaemonhelper pattern/tmp/swarm-daemon-tests.md🤖 Generated with Claude Code