refactor: add socket response helpers and argument extractors#331
Merged
refactor: add socket response helpers and argument extractors#331
Conversation
Add helper functions to socket package for creating responses: - ErrorResponse(format, args...) for error responses with formatting - SuccessResponse(data) for success responses Add argument extraction helpers in daemon: - getOptionalStringArg for optional string arguments with defaults - getOptionalBoolArg for optional bool arguments with defaults Refactored all 50 handler response patterns in daemon.go to use the new helpers, improving consistency and reducing boilerplate. This also simplifies fork config parsing from ~12 lines to ~4 lines. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
aronchick
pushed a commit
to aronchick/multiclaude
that referenced
this pull request
Jan 29, 2026
…c#331) Add helper functions to socket package for creating responses: - ErrorResponse(format, args...) for error responses with formatting - SuccessResponse(data) for success responses Add argument extraction helpers in daemon: - getOptionalStringArg for optional string arguments with defaults - getOptionalBoolArg for optional bool arguments with defaults Refactored all 50 handler response patterns in daemon.go to use the new helpers, improving consistency and reducing boilerplate. This also simplifies fork config parsing from ~12 lines to ~4 lines. Co-authored-by: Test User <test@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add helper functions to
socketpackage for creating responses:ErrorResponse(format, args...)- creates error responses with printf-style formattingSuccessResponse(data)- creates success responses with optional dataAdd argument extraction helpers in
daemon:getOptionalStringArg- extracts optional string arguments with defaultsgetOptionalBoolArg- extracts optional bool arguments with defaultsRefactored all 50 handler response patterns in
daemon.goto use the new helpersSimplified fork config parsing from ~12 lines to ~4 lines using struct literal with helpers
Changes
internal/socket/socket.gointernal/daemon/daemon.goImpact
Test plan
go build ./...compiles successfullygo test ./internal/daemon/...passes (42 tests)go test ./internal/socket/...passesgo test ./...full suite passes🤖 Generated with Claude Code