Skip to content

Fixes naming inconsistencies between methods and functions#67

Merged
dllargent merged 3 commits intomasterfrom
naming
Jan 2, 2026
Merged

Fixes naming inconsistencies between methods and functions#67
dllargent merged 3 commits intomasterfrom
naming

Conversation

@JasonYoder2026
Copy link
Collaborator

No description provided.

Copy link
Owner

@dllargent dllargent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Sound.py, it appears that you may be changing the parameter named frameNum to index, which I am OK with. However, there are still references to frameNum. Is that correct, or an oversight? For example, I see frameNum in lines 279, 284, 296, 301, 312, ... 418, 420, 428, ...

@JasonYoder2026
Copy link
Collaborator Author

@dllargent I can change those if you would like, but I didn't see much of a need to. The instances I changed had situations like this:

  • setSampleValueAt() has a parameter index (the function called this method)
  • setSampleValue() had a parameter named frameNum that index was passed as when setSampleValueAt called it

I deleted the setSasmpleValueAt since all it did was call setSampleValue. and changed setSampleValue to setSampleValueAt and renamed the parameter to index to match any calls with explicit parameters.

@dllargent dllargent merged commit 2c4f797 into master Jan 2, 2026
2 checks passed
@dllargent dllargent deleted the naming branch January 2, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants