This repository was archived by the owner on Oct 12, 2022. It is now read-only.
  
  
  - 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 414
Fix Issue 23157 - undefined reference to `__cmsg_nxthdr' on Alpine Li… #3830
          
     Open
      
      
            tom-tan
  wants to merge
  1
  commit into
  dlang:stable
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
tom-tan:fix-CMSG_NXTHDR-for-muslc
  
      
      
   
  
    
  
  
  
 
  
      
    base: stable
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Thanks for your pull request and interest in making D better, @tom-tan!  We are looking forward to reviewing it, and you should be hearing from a maintainer soon. 
 Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
 Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3830" | 
3e4cf77    to
    210d4c8      
    Compare
  
    
              
                    ljmf00
  
              
              reviewed
              
                  
                    Jun 4, 2022 
                  
              
              
            
            
              
                    ljmf00
  
              
              approved these changes
              
                  
                    Jun 4, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
| Can you please rebase this to restart the CI? | 
…nux (musl libc) Make __CMSG_* and __MHDR_END private
b0ed0a0    to
    7cac81e      
    Compare
  
    | Buildkite succeeded now, but FreeBSD still has heisenbugs. Seems unrelated. | 
              
                    RazvanN7
  
              
              approved these changes
              
                  
                    Jun 9, 2022 
                  
              
              
            
            
              
                    WalterBright
  
              
              approved these changes
              
                  
                    Aug 9, 2022 
                  
              
              
            
            
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
…nux (musl libc)
The current definition of
CMSG_NXTHDRuses__cmsg_nxthdrinternally but__cmsg_nxthdris not provided on Alpine Linux (musl libc).This request fixes the issue 23157 by fixing the definiiton of
CMSG_NXTHDR.Here is a corresponding definition in musl libc header: https://git.musl-libc.org/cgit/musl/tree/include/sys/socket.h#n357