Fix error message of assert_raise #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 26, 2016 10:14
Since commit f6b140c assert_raise started using the second argument of assert for error messages. The error message was always "got nil instead". The reason is that the local variable "exception" only has a value in case of success. In case of failure its value is nil. This commit adds tests to catch the error and fixes assert_raise to construct the expected error message in case of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit f6b140c
assert_raisestarted using the second argument ofassertfor error messages. The error message was always"got nil instead". The reason is that the local variableexceptiononly has a value in case of success. In case of failure its value isnil.This pull request adds a test for the error message of each assertion method (
assert,assert_equalandassert_raise) and fixesassert_raiseto construct the expected error message in case of failure.