[18.0] vcp_*: some other improvments#4
Conversation
legalsylvain
force-pushed
the
18.0-add-vcp-BIS
branch
from
ca59fb5 to
bae7eb7
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…ived repositories
…' field. (https://github.com/orgs/community/discussions/24442). It's an important field that show if the repo is active, or totally abandonned
…elated repositories
legalsylvain
force-pushed
the
18.0-add-vcp-BIS
branch
from
d78b772 to
5f551f7
Compare
… modules. Otherwise, if we recreate after a repository branch, it will create odoo modules duplicated
…ilable. By default, set a filter to hide modules without versions
…re matching a given pattern. It allows to ignore ocabot branches, in case of fetching OCA repositories
…Fix body storage. (convert markdown into html)
legalsylvain
force-pushed
the
18.0-add-vcp-BIS
branch
from
b39ddeb to
32e0be3
Compare
sebastienbeau
left a comment
sebastienbeau
left a comment
There was a problem hiding this comment.
First thanks for the work and the detail in the commit, the review was easier to do !
👍 for managing the fork and the archived repo
👍 for the regex for matching only needed branch
👍 for all the UI improvement and code cleanup
I really like what we have !
(code review and fonctional test)
| version = fields.Char(required=True) | ||
| repository_branch_id = fields.Many2one( | ||
| "vcp.repository.branch", | ||
| required=True, |
There was a problem hiding this comment.
I have a doubt for this point. I am ok with the ondelete cascade. But I am not sure about the required.
I have case, where I have other source for creating odoo.module and odoo.module.version. My customer have a module that push to our Odoo which module are installed. Some time (rare case) I have module that are not in OCA or Akretion repo. So the module will not exist in my Odoo and now I create it on the fly, so I do not have repository. I am not sure if I will still process like that with this new version (I need to think twice about it)
So it's not blocking for now, I just have doubt
3 participants
See commit one by one for detailed changes.
Screenshots
change markdown to html to store correctly comments bodies & reviews bodies.
exemple :