vscode-extensions: detect vsix sources and generate packages automatically#353
Closed
danielphan2003 wants to merge 1 commit intodivnix:mainfrom
danielphan2003:vscode-extensions
Closed
vscode-extensions: detect vsix sources and generate packages automatically#353danielphan2003 wants to merge 1 commit intodivnix:mainfrom danielphan2003:vscode-extensions
danielphan2003 wants to merge 1 commit intodivnix:mainfrom
danielphan2003:vscode-extensions
Conversation
blaggacao
reviewed
Aug 2, 2021
Comment on lines
+10
to
+14
| isVsix = hasSuffix ".vsix"; | ||
|
|
||
| isVsixPackage = hasSuffix ".VSIXPackage"; | ||
|
|
||
| isVscodeExt = name: (isVsix name) || (isVsixPackage name); |
blaggacao
reviewed
Aug 2, 2021
| @@ -0,0 +1,11 @@ | |||
| { lib, vscode-utils, sources }: | |||
| let | |||
| inherit (vscode-utils) isVscodeExt mkVscodeExtensions; | |||
Contributor
There was a problem hiding this comment.
Those look like convenience library functions that we might want to discuss adding in digga?
Contributor
There was a problem hiding this comment.
or alternatively a divnix/vsext (to decouple release cycles)!!!
Contributor
|
IMO, also |
Author
|
Superseeded by https://github.com/divnix/devos-ext-lib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at PR #348, I notice that we can improve how
vscode-extensionshandles generated vsix source in pkgs/sources.toml.This PR aims to
mkVscodeExtensionwith auto-generated meta attributes and passthru values such asmeta.homepage,meta.downloadPage,meta.changelog,meta.license,meta.maintainers,meta.platforms,{drv}Phase, etc.Therefore, the following code snippet can be simplified into:
The
passthrucan be generated throughbudscript, although I will need to test more of this later.