Conversation
add completion for built-in function `<type>::into(input)` also refactor `completion::types::FunctionTemplate`, removed redundant field `snippet_base` and add new field `snippet`.
using completion with function kind makes unpleasant overlap with word `into` and it structure `<Input>::into(input)`, so we used snippet completion kind for clean visual effect.
Include in description either it built-in or jet before function signature. Also add after signature `---` for clean separation with it's description.
Initially, `RopeSlice.as_str()` was used because it doesn't create a copy of the string, but it can fail if the `RopeSlice` is not continuous in memory. So, we convert the `RopeSlice` to a string, because this will not throw an error for large lines, and the `references` function is not called often enough for us to care about copying one line.
also change goto-definition to return range of symbol if we stay on definition, because this actually triggers reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add completion for type casting in the form of a snippet. Right now
TypeCastcompletion is insideFunctionTemplate, which is technically not wrong, but it introduces some complications (like an if statement in the conversion fromFunctionTemplatetoCompletionIteminside completion/mod.rs). also moved theTypeCastdocumentation into a separate function to avoid the clippy complaint about too many lines.add a
Referencesfeature for functions, which works on a function definition and highlights all calls of that function. It's not highlighting the definition itself, though some language servers do that, so we could implement this too.