Add support for custom publisher identifier in ISO9660#346
Merged
deitch merged 1 commit intodiskfs:masterfrom Mar 19, 2026
Merged
Add support for custom publisher identifier in ISO9660#346deitch merged 1 commit intodiskfs:masterfrom
deitch merged 1 commit intodiskfs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @deitch
Thanks for the package!
This PR adds support for providing the publisher id to the finalize function for ISOs. The PR itself is straightforward, and the test took an approach of validating the field by reading the field using the bytes offset as gleaned from
volume_descriptor.go.Appreciate the review and looking forward to have this enhancement in the upstream.