-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: remove usage of the prefer-global rules #11279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11279 +/- ##
==========================================
- Coverage 44.97% 44.92% -0.06%
==========================================
Files 317 317
Lines 18222 18202 -20
Branches 1817 1815 -2
==========================================
- Hits 8196 8177 -19
+ Misses 10013 10012 -1
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qjuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
including api-extractor in this change is correct
almeidx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the eslint.config.js files in the templates for create-discord-bot too? Otherwise the linter will (probably) fail when people create a new project using it
1717188 to
1157f40
Compare
almeidx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I suggested removing the imports from built-ins, I was referring to standard globals (URL, URLSearchParams, Blob, etc.).
I think we should keep the node-specific things imported still. While they will (probably) work on other runtimes without the explicit import, I think it's better in this case to have an explicit import so it's extremely clear that we are expecting the implementation from/for node.
Additionally, I found some other globals which are still being imported while skimming over: File, Blob, and performance`.
should I have ignored api-extractor?
Closes #11272