Skip to content

Conversation

@didinele
Copy link
Member

@didinele didinele commented Nov 17, 2025

should I have ignored api-extractor?

Closes #11272

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Skipped Skipped Nov 28, 2025 10:39am
discord-js-guide Skipped Skipped Nov 28, 2025 10:39am

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.92%. Comparing base (5dea946) to head (beb170a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11279      +/-   ##
==========================================
- Coverage   44.97%   44.92%   -0.06%     
==========================================
  Files         317      317              
  Lines       18222    18202      -20     
  Branches     1817     1815       -2     
==========================================
- Hits         8196     8177      -19     
+ Misses      10013    10012       -1     
  Partials       13       13              
Flag Coverage Δ
builders 81.15% <ø> (-0.01%) ⬇️
core 0.90% <ø> (ø)
proxy 65.47% <ø> (-0.41%) ⬇️
rest 87.55% <ø> (-0.02%) ⬇️
util 43.75% <ø> (ø)
ws 36.20% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including api-extractor in this change is correct

Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the eslint.config.js files in the templates for create-discord-bot too? Otherwise the linter will (probably) fail when people create a new project using it

@didinele didinele force-pushed the chore/no-prefer-global branch from 1717188 to 1157f40 Compare November 28, 2025 10:34
@vercel vercel bot temporarily deployed to Preview – discord-js November 28, 2025 10:36 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide November 28, 2025 10:36 Inactive
@didinele didinele requested a review from a team as a code owner November 28, 2025 10:39
@vercel vercel bot temporarily deployed to Preview – discord-js November 28, 2025 10:39 Inactive
@vercel vercel bot temporarily deployed to Preview – discord-js-guide November 28, 2025 10:39 Inactive
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I suggested removing the imports from built-ins, I was referring to standard globals (URL, URLSearchParams, Blob, etc.).

I think we should keep the node-specific things imported still. While they will (probably) work on other runtimes without the explicit import, I think it's better in this case to have an explicit import so it's extremely clear that we are expecting the implementation from/for node.


Additionally, I found some other globals which are still being imported while skimming over: File, Blob, and performance`.

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

Remove usage of n/prefer-global rules across the monorepo

6 participants