rate limit: Limit should apply to all routes#1136
Open
jwdeitch wants to merge 1 commit intodingo:masterfrom
Open
rate limit: Limit should apply to all routes#1136jwdeitch wants to merge 1 commit intodingo:masterfrom
jwdeitch wants to merge 1 commit intodingo:masterfrom
Conversation
Exceeding the rate limit should return 403 for all further requests; the route of the request should not matter. The current behavior is such that exceeding the rate limit will only 403 that particular route.
Member
|
@jwdeitch This is a good PR, Could you resolve the conflict and update the PR? |
Member
|
Wouldn't this depend on whether the api throttle is placed in a route group or a particular route? If particular route or even group within larger group - then it shouldn't I would think apply to all routes? |
|
Actually, the middleware should throw a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceeding the rate limit should return 403 for all further requests; the route of the request should not matter.
The current behavior is such that exceeding the rate limit will only 403 that particular route.