Improve accessibility support for the lightbox dialog and counter#2184
Open
preethiramiah wants to merge 5 commits into
Open
Improve accessibility support for the lightbox dialog and counter#2184preethiramiah wants to merge 5 commits into
preethiramiah wants to merge 5 commits into
Conversation
Add `aria-modal` and `aria-label` attributes to `dialog`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves screen reader support for the PhotoSwipe dialog:
aria-modal="true"on the root.pswpelement.aria-labelon the root, configurable via a newariaLabeloption and defaults to"Full-size image gallery".role="status"on the counter element - the counter ("2 / 10") updates on every slide change; marking it as a live status region lets screen readers announce the current position as the user navigates.