k8s: patch get_kubeconfig to work around deserialization issue#612
Open
andrewsomething wants to merge 1 commit intomainfrom
Open
k8s: patch get_kubeconfig to work around deserialization issue#612andrewsomething wants to merge 1 commit intomainfrom
andrewsomething wants to merge 1 commit intomainfrom
Conversation
andrewsomething
force-pushed
the
asb/kubeconfig
branch
from
eb3de3d to
a742b3c
Compare
andrewsomething
force-pushed
the
asb/kubeconfig
branch
from
a742b3c to
3260b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autorest does not handle
application/yamlresponse content correctly. This overrides the generatedget_kubeconfigto work around the problem by both skipping deserialization in the content policy and returning a string instead ofresponse.json(). A string is the expected return here;get_credentialscan be used for structured response. The usecase forget_kubeconfigis outputting the file contents.Fixes #264