Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@stevenhua0320 stevenhua0320 commented Oct 21, 2025

@zmx27 Ready for review

Copy link
Contributor

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that srxplanar is actually open-source, so it would use the usual skpkg workflow files

@stevenhua0320
Copy link
Contributor Author

I believe that srxplanar is actually open-source, so it would use the usual skpkg workflow files

Given that it is in private repo, is there any unmodified srxplanar that should be edited here?

@stevenhua0320 stevenhua0320 requested a review from zmx27 October 23, 2025 14:41
Copy link
Contributor

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise this looks good

headless: false
run: |
conda install pre-commit
pre-commit run --all-files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also set the python_version to 3.13 to avoid the CI failing in future PRs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that pyproject.toml has python 3.12-3.14, but I thought we are releasing everything in 3.11-3.13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Let's now change it back to 3.11-3.13 because originally we think release with python 3.12-3.14

headless: false
python_version: "3.13"
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need codecov token if we're calling the no-codecov workflow I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is open source so we want to call codecove

@zmx27
Copy link
Contributor

zmx27 commented Oct 24, 2025

@sbillinge ready for review

@sbillinge
Copy link
Contributor

THis PR went a bit astray because we got confused about whether this repo was private or public....it is public. So the workflows all need to be the standard ones from scikit-package without changing them. I will close this and we can do it over. @stevenhua0320 you may want to run package create diffpy.xpdfsuite some random place on your computer away from this project, so you can regenerate the exact workflow files that we want, then copy them over to this repo from there. That way we are sure that the workflow files you are getting are the exact ones we want.

We also tried to move to 3.14 but cannot yet because not all our dependencies are moved over so we will keep our pyproject.toml showing 3.11 - 3.13.

@sbillinge
Copy link
Contributor

closing so we can replace with a clean version of the workflows.

@sbillinge sbillinge closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants