-
Notifications
You must be signed in to change notification settings - Fork 14
skpkg: add CI and issue/PR templates #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that srxplanar is actually open-source, so it would use the usual skpkg workflow files
Given that it is in private repo, is there any unmodified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise this looks good
| headless: false | ||
| run: | | ||
| conda install pre-commit | ||
| pre-commit run --all-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also set the python_version to 3.13 to avoid the CI failing in future PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that pyproject.toml has python 3.12-3.14, but I thought we are releasing everything in 3.11-3.13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Let's now change it back to 3.11-3.13 because originally we think release with python 3.12-3.14
| headless: false | ||
| python_version: "3.13" | ||
| secrets: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need codecov token if we're calling the no-codecov workflow I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is open source so we want to call codecove
|
@sbillinge ready for review |
|
THis PR went a bit astray because we got confused about whether this repo was private or public....it is public. So the workflows all need to be the standard ones from scikit-package without changing them. I will close this and we can do it over. @stevenhua0320 you may want to run We also tried to move to 3.14 but cannot yet because not all our dependencies are moved over so we will keep our pyproject.toml showing 3.11 - 3.13. |
|
closing so we can replace with a clean version of the workflows. |
@zmx27 Ready for review