Fix stop condition and add Y/A normalization #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## john-development #141 +/- ##
===================================================
Coverage ? 91.96%
===================================================
Files ? 7
Lines ? 112
Branches ? 0
===================================================
Hits ? 103
Misses ? 9
Partials ? 0 🚀 New features to boost your workflow:
|
|
I will merge this, though we should definitely revisit whether we want to be implementing our own optimizer rather than using a standard one.... |
|
I agree. Already certain portions have been made more standard, such as using cvxpy instead of the custom mkr_box in the original. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program now correctly stops when objective function improvement slows down. Since we are not yet using a Hessian like the MATLAB, we converge slower and a stricter condition and longer runtime would be needed for the same performance.