Skip to content

Conversation

@tinatn29
Copy link
Contributor

No description provided.

@tinatn29 tinatn29 marked this pull request as draft June 17, 2025 20:27
@tinatn29 tinatn29 marked this pull request as ready for review June 17, 2025 20:37
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something a bit weird happened here. All the CI was deleted and replaced with an empty yml file. I don't think this is the behavior we want. Did you do this to get CI to pass?

For many of these migrations it is ok to have CI failing until we reach the point we want it passing.

@tinatn29
Copy link
Contributor Author

no I didn't do it manually... The only manual changes I made were on .codespell/ignore_words.txt. I think when I did git add <a bunch of files> per the instructions I didn't make sure to keep the old versions... I'll close and redo this PR.

@tinatn29 tinatn29 closed this Jun 18, 2025
@sbillinge
Copy link
Contributor

interesting. Before you redo (if you didn't already) let's have a 30 minute call and get the process started together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants