- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
          test: copy_examples test
          #65
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @sbillinge ready for review | 
| Looks good as long as all the edits were brought over correctly! | 
| @sbillinge compared them side-by-side and the two PRs are the same | 
| Let's then implement the method | 
| @sbillinge ready for review. All tests pass except one that captures the bad output. Im still figuring out how to capture the statement, but wanted to make a push so you can leave comments on function styling and such | 
| I've included a test for the forced overwrite copy of examples. | 
| this still seems to be failing tests | 
| @sbillinge Pytest is passing locally now but this is failing CI for some reason. I'm trying to debug on my fork cadenmyers13#8 and I can't quite figure out whats going on. There is a shell script that runs ( @Tieqiong Do you know what might be causing this? FYI, I forgot to pull from upstream before creating this branch so i had to merge the python 3.14 support 🤦♂️ | 
| @cadenmyers13 seems like tests for srreal and pyobjcryst didn't run, probably not compatible with python 3.14 resulting in installation issue. You can see the test env runs on 3.14, which roots from recent 3.14 update on  | 
| We also are out of free credits. Even though CMI is open software, it turns out Mac and Windows builds are not free even then, and CMI running all it's examples burned through our allocation. This is also causing tests to fail, at least the merge to main tests | 
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   82.93%   83.24%   +0.30%     
==========================================
  Files          13       12       -1     
  Lines        1313     1349      +36     
==========================================
+ Hits         1089     1123      +34     
- Misses        224      226       +2     
 🚀 New features to boost your workflow:
 | 
| @Tieqiong Okay, i added    @sbillinge On another note, is this how the warning message should be handled/captured for the case when the user tries to copy to a pre-existing directory? | 
| warnings that are raised correctly should pass green in tests. We would like to write a test that tests that a warning is raised correctly. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now except hte warning. We should think a bit about this. Let's say there is one file that is duplicate. Do we want the code to crash and not copy anything? Or do we want it to copy everything it can, but just not copy the duplicate and throw a warning? Which is better behavior?
| 
 @sbillinge I like copying everything it can and throw the warning. I like this because if the user wants a restart on a specific file, they can remove this file then run  | 
cleaned up version of this PR: #60
closes: #56