Skip to content

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Oct 13, 2025

What problem does this PR address?

Closes #57

Move get_package_dir from __init__.py to packsmanager.py

@ycexiao ycexiao marked this pull request as ready for review October 13, 2025 19:04
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.93%. Comparing base (7659ba1) to head (440d54b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files          13       13           
  Lines        1313     1313           
=======================================
  Hits         1089     1089           
  Misses        224      224           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao
Copy link
Contributor Author

ycexiao commented Oct 13, 2025

@sbillinge, it's ready for review.

@sbillinge sbillinge merged commit d0744a7 into diffpy:main Oct 14, 2025
5 checks passed
@sbillinge
Copy link
Contributor

Yes, that's it. Thanks ,@ycexiao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revisit get_package_dir

2 participants