Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Oct 13, 2025

closes #64

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.93%. Comparing base (7659ba1) to head (50a9eed).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files          13       13           
  Lines        1313     1313           
=======================================
  Hits         1089     1089           
  Misses        224      224           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

@sbillinge I think this can be merged? fyi

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Please confirm that a all mentions of 3.11/3.13 are updatd in docs/readme/workflows are hanlded.

@cadenmyers13
Copy link
Contributor Author

@sbillinge Looks good everywhere. Looks like this change was already made under release scripts too https://github.com/scikit-package/release-scripts/tree/main/.github/workflows

@sbillinge sbillinge merged commit 9f47832 into diffpy:main Oct 17, 2025
5 checks passed
@sbillinge
Copy link
Contributor

yay, passed tests in 3.14!

@sbillinge
Copy link
Contributor

the matrix workflow is failing though:
image

@sbillinge
Copy link
Contributor

it is running the wrong versions of python. We may need a PR in the centralized workflow that Bob missed.

@sbillinge
Copy link
Contributor

Also, we will need a release milestone and a release issue created on every repo. We have to decide if that should be a patch release or a proper release, i.e., 3.1.0 -> 3.1.1 or 3.2.0. Could you google around and see what the consensus is?

@cadenmyers13 cadenmyers13 deleted the bump-version branch October 28, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for python 3.14 and remove support of python 3.11

2 participants