-
Notifications
You must be signed in to change notification settings - Fork 5
feat: place examples in pack directories for cli #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0f3293f
move examples under pdf dir
cadenmyers13 c5c9f84
edit cli to reflect new path change
cadenmyers13 1092dcb
news
cadenmyers13 14102ad
fix typo
cadenmyers13 d423377
Revise examples in news/ex-path.rst for clarity
sbillinge 683b4c3
rm type hint
cadenmyers13 71f9de4
merge to local: move news from added to changed
cadenmyers13 3a1ee8b
change list_examples to map_pack_to_examples which returns a dict
cadenmyers13 d3b531c
change variable name to reflect action properly
cadenmyers13 73d083e
change function name
cadenmyers13 61a9bd6
update docstring
cadenmyers13 012a45e
Merge branch 'main' of github.com:diffpy/diffpy.cmi into ex-path
cadenmyers13 d90a271
tests for help command, listing examples, and copying examples
cadenmyers13 c12f6b5
fix monkeypatch debugging code
cadenmyers13 c0bead8
update function names to be more readable
cadenmyers13 63ac630
test map pack to examples function
cadenmyers13 e0a2c75
add no packs, no examples case
cadenmyers13 81fa5cf
make sure directory was created
cadenmyers13 10771b1
add tests for copy_example
cadenmyers13 4ee36af
Add Error if pack or example doesnt exist
cadenmyers13 4019e36
Merge branch 'main' ex-path to see core example
cadenmyers13 65fd2c7
map packs function test, simplified
cadenmyers13 74e992b
add condition that catches extra slashes
cadenmyers13 d53fab8
test copy behavior
cadenmyers13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Changed:** | ||
|
|
||
| * change examples directory structure to insert the name of the ``pack" that the examples exemplify. | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,27 +52,33 @@ def _installed_examples_dir() -> Path: | |
| ) | ||
|
|
||
|
|
||
| def list_examples() -> List[str]: | ||
| """List installed example names. | ||
| def get_examples_by_pack() -> dict[str, List[str]]: | ||
| """Return a dictionary mapping pack name -> list of example | ||
| subdirectories. | ||
|
|
||
| Returns | ||
| ------- | ||
| list of str | ||
| Installed example directory names. | ||
| dict: | ||
| pack name -> list of example subdirectory names | ||
| """ | ||
| root = _installed_examples_dir() | ||
| if not root.exists(): | ||
| return [] | ||
| return sorted([p.name for p in root.iterdir() if p.is_dir()]) | ||
| return {} | ||
| examples_by_pack = {} | ||
| for pack_dir in sorted(root.iterdir()): | ||
| if pack_dir.is_dir(): | ||
| exdirs = sorted(p.name for p in pack_dir.iterdir() if p.is_dir()) | ||
| examples_by_pack[pack_dir.name] = exdirs | ||
| return examples_by_pack | ||
|
|
||
|
|
||
| def copy_example(example: str) -> Path: | ||
| def copy_example(pack_example: str) -> Path: | ||
| """Copy an example into the current working directory. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| example : str | ||
| Example directory name under the installed examples root. | ||
| Example in the form ``<pack>/<exdir>``. | ||
|
|
||
| Returns | ||
| ------- | ||
|
|
@@ -81,15 +87,20 @@ def copy_example(example: str) -> Path: | |
|
|
||
| Raises | ||
| ------ | ||
| ValueError | ||
| If the format is invalid. | ||
| FileNotFoundError | ||
| If the example directory does not exist. | ||
| FileExistsError | ||
| If the destination directory already exists. | ||
| """ | ||
| src = _installed_examples_dir() / example | ||
| if "/" not in pack_example: | ||
| raise ValueError("Example must be specified as <pack>/<exdir>") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enforces new format of copying examples. This format is |
||
| pack, exdir = pack_example.split("/", 1) | ||
| src = _installed_examples_dir() / pack / exdir | ||
| if not src.exists() or not src.is_dir(): | ||
| raise FileNotFoundError(f"Example not found: {example}") | ||
| dest = Path.cwd() / example | ||
| raise FileNotFoundError(f"Example not found: {pack_example}") | ||
| dest = Path.cwd() / exdir | ||
| if dest.exists(): | ||
| raise FileExistsError(f"Destination {dest} already exists") | ||
| copytree(src, dest) | ||
|
|
@@ -163,7 +174,9 @@ def _build_parser() -> argparse.ArgumentParser: | |
| _parser=p_example | ||
| ) | ||
| p_example_copy = sub_ex.add_parser("copy", help="Copy an example to CWD") | ||
| p_example_copy.add_argument("name", metavar="EXAMPLE", help="Example name") | ||
| p_example_copy.add_argument( | ||
| "name", metavar="EXAMPLE", help="Example name <pack>/<exdir>" | ||
| ) | ||
| p_example_copy.set_defaults(_parser=p_example) | ||
| p_example.set_defaults(example_cmd=None) | ||
|
|
||
|
|
@@ -339,10 +352,11 @@ def _cmd_example(ns: argparse.Namespace) -> int: | |
| print(f"Example copied to: {out}") | ||
| return 0 | ||
| if ns.example_cmd == "list": | ||
| for g in list_examples(): | ||
| print(g) | ||
| for pack, examples in get_examples_by_pack().items(): | ||
| print(f"{pack}:") | ||
| for ex in examples: | ||
| print(f" - {ex}") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prints examples in the format of instead of |
||
| return 0 | ||
|
|
||
| plog.error("Unknown example subcommand.") | ||
| ns._parser.print_help() | ||
| return 2 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returns a dict, mapping pack name (str) to its corresponding list of examples (list of strs). This replaces previous format were all the examples are stored in one list.