[ECMAScript6BestPractices] fix common-serve.js
#2773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
commented
Nov 27, 2025
lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js
Outdated
Show resolved
Hide resolved
lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js
Outdated
Show resolved
Hide resolved
lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-ECMAScript6BestPractices-fix-common-serve
branch
5 times, most recently
from
1f6404a to
b5775ec
Compare
Pankraz76
commented
Nov 28, 2025
Pankraz76
force-pushed
the
fix-ECMAScript6BestPractices-fix-common-serve
branch
3 times, most recently
from
ca950be to
8533f98
Compare
Pankraz76
commented
Nov 30, 2025
| var format_data = req.body; | ||
| tsfmt.processString("spotless-format-string.ts", format_data.file_content, format_data.config_options).then(resultMap => { | ||
| /* | ||
| export interface ResultMap { |
Contributor
Author
There was a problem hiding this comment.
do we still need this?
Pankraz76
force-pushed
the
fix-ECMAScript6BestPractices-fix-common-serve
branch
from
8533f98 to
78a5764
Compare
Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
force-pushed
the
fix-ECMAScript6BestPractices-fix-common-serve
branch
from
78a5764 to
cd3f993
Compare
added 5 commits
November 30, 2025 14:00
Signed-off-by: Vincent Potucek <[email protected]>
Signed-off-by: Vincent Potucek <[email protected]>
Signed-off-by: Vincent Potucek <[email protected]>
Signed-off-by: Vincent Potucek <[email protected]>
Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
commented
Nov 30, 2025
|
|
||
| app.post("/shutdown", (req, res) => { | ||
| res.status(200).send("Shutting down"); | ||
| setTimeout(async () => { |
Contributor
Author
There was a problem hiding this comment.
assuming if we fail here we still would have send out 200 before.
| console.error("Error during shutdown:", err); | ||
| } | ||
| }, 200); | ||
| res.ok().send("Graceful shutdown."); |
Contributor
Author
There was a problem hiding this comment.
It should be safe to make this the last call. The only potential issue is if a third-party tool relies on the current log parsing, but that’s unlikely. We’re updating it to present tense for consistency with standard logging.
added 3 commits
November 30, 2025 14:37
Signed-off-by: Vincent Potucek <[email protected]>
Signed-off-by: Vincent Potucek <[email protected]>
…-common-serve' into fix-ECMAScript6BestPractices-fix-common-serve # Conflicts: # lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js
Pankraz76
commented
Nov 30, 2025
| 'ReturnValueIgnored', // We don`t want to use ErrorProne's annotations. | ||
| ) | ||
| error( | ||
| 'ReturnValueIgnored', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabler for:
ECMAScript6BestPractices#2768related to:
ECMAScript6BestPracticesendless comment copy bug. openrewrite/rewrite#6330