Use palantir-java-format as default formatter in RemoveUnusedImportsStep
#2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
fix-palantir-java-format
branch
2 times, most recently
from
887d3c4 to
d6329c5
Compare
Pankraz76
commented
Jul 2, 2025
...c/test/java/com/diffplug/spotless/java/RemoveUnusedImportsStep_withGoogleJavaFormatTest.java
Show resolved
Hide resolved
|
Update changelogs and docs and this is good to merge. |
|
nice thanks. Actually its kind of refactoring but still changed some logic i would like to test. Maybe test afterwards, not to block shipment. Will update thanks. |
Pankraz76
changed the title
palantir-java-format as default formatter in RemoveUnusedImportsSteppalantir-java-format as default formatter in RemoveUnusedImportsStep
Pankraz76
force-pushed
the
fix-palantir-java-format
branch
from
d6329c5 to
2ebe138
Compare
Pankraz76
commented
Jul 3, 2025
| @Test | ||
| void testDefaults() { | ||
| assertEquals("palantir-java-format", defaultFormatter()); | ||
| assertEquals("palantir-java-format", DEFAULT_FORMATTER); |
There was a problem hiding this comment.
convention is same package, to be able to access package private.
done.
which one? |
|
!!!Revert!!! This is wrong/incomplete: Sorry, this pull request couldn’t be reverted automatically. It may have already been reverted, or the content may have changed since it was merged. We still using google under the hood: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
palantir-java-formatas default formatter inRemoveUnusedImportsStepRemoveUnusedImportsStepleftovers palantir/palantir-java-format#1337RemoveUnusedImportsStep#2533