docs: fix stale spec anchor "The transparent proxy" → "Iframe Renderer"#161
Merged
Conversation
Two doc-pointer comments reference a dor-browser.md section that does not exist. When dor-iframe.md + dor-agent-browser.md were unified into dor-browser.md (#156), the proxy moved under the "Iframe Renderer" section; the cleanup in 595531c missed these two because they wrap the section title across two comment lines. Match the sibling pointers in iframe-proxy.ts, iframe-proxy-rewrite.ts, and iframe-proxy-types.ts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
5682cd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7a46c3f.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-spec-anchor-iframe-rende.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale spec anchor: "The transparent proxy" → "Iframe Renderer"
Two source-comment doc-pointers reference a
docs/specs/dor-browser.mdsection that does not exist:lib/src/lib/platform/types.ts:179—// iframe surface support (see docs/specs/dor-browser.md → "The transparent proxy")vscode-ext/src/iframe-proxy-host.ts:5—* ... see docs/specs/dor-browser.md → "The transparent proxy"When the iframe and agent-browser specs were unified into
dor-browser.md(#156), the proxy ended up documented under the "Iframe Renderer" section (docs/specs/dor-browser.mdline 302). There is no "The transparent proxy" heading anywhere in the file, so both anchors dangle. Commit 595531c ("specs: fix code doc-pointer anchors") swept most of these but missed these two — they're the only anchors that wrap the section title across two comment lines, so a single-line grep didn't catch them.The sibling pointers for the very same proxy code already point at the right section:
lib/src/host/iframe-proxy.ts:3→"Iframe Renderer"lib/src/host/iframe-proxy-rewrite.ts:3→"Iframe Renderer"lib/src/lib/platform/iframe-proxy-types.ts:3→"Iframe Renderer"This PR updates the two stragglers to match.
Comment-only change — no behavior change, so no test is added. Verified by grep that no
→ "The transparent proxy"anchor remains inlib/,vscode-ext/, orstandalone/(the lone remaining "transparent proxy" mention is descriptive prose, not a section anchor).