feat: movable-view change 事件支持UI线程调用 - #2506
Open
yandadaFreedom wants to merge 10 commits into
Open
Conversation
hiyuki
reviewed
Jul 14, 2026
hiyuki
reviewed
Jul 14, 2026
hiyuki
reviewed
Jul 14, 2026
added 6 commits
July 20, 2026 11:23
hiyuki
requested changes
Jul 24, 2026
hiyuki
left a comment
hiyuki
left a comment
Collaborator
There was a problem hiding this comment.
发现一个会导致 workletChange 与实际动画位置不同步的问题，建议修复后再合并。
| friction, | ||
| () => { | ||
| xInertialMotion.value = false | ||
| (finished) => { |
Collaborator
There was a problem hiding this comment.
[P2] 这里只在 withTiming 完成后触发一次 workletChange，惯性动画期间 offsetX/offsetY 持续变化却没有回调；上面的越界回弹和受控 x/y 动画则会在动画刚开始时直接回调目标坐标。依赖该回调同步其他 UI 的场景会在动画期间冻结或提前跳到终点，与“位置变化时在 UI 线程立即触发”的语义不符。建议通过 useAnimatedReaction（或统一的共享位置观察路径）监听 offsetX/offsetY 的实际变化，并用 shared value 标记 touch / friction / out-of-bounds source。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.