fix: Collection validation in scheme [DHIS2-22026] - #25018
Merged
Conversation
|
jbee
approved these changes
Sep 3, 2026
maikelarabori
enabled auto-merge (squash)
September 3, 2026 11:24
luciano-fiandesio
approved these changes
Sep 3, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a validation that triggers for Collection types, enforcing the max size of 255 elements.
This limitation is a mistake and shouldn't be there unless a
max/minsize is defined programmatically at theentitylevel.The PR removes this enforcement for Collection types. For types where a default
maxsize still needs some enforcement (by default), the flow still applies it as expected, so no breaking changes in this sense.Also, with this change, the
maxlimit on Periods is no longer required. Hence, they were removed.