Skip to content

feat: use identifiable token in data item search + ui upgrade (DHIS2-6568) (DHIS2-20698)#3454

Merged
janhenrikoverland merged 4 commits intomasterfrom
feat/use-identifiable-token-in-data-item-search
Feb 11, 2026
Merged

feat: use identifiable token in data item search + ui upgrade (DHIS2-6568) (DHIS2-20698)#3454
janhenrikoverland merged 4 commits intomasterfrom
feat/use-identifiable-token-in-data-item-search

Conversation

@janhenrikoverland
Copy link
Collaborator

@janhenrikoverland janhenrikoverland commented Feb 10, 2026

Implements DHIS2-6568

Also includes a @dhis2/ui upgrade DHIS2-20698

Requires dhis2/analytics#1807

Added a cypress test for search by uid.

Description

See dhis2/analytics#1807

Quality checklist

Screenshots

See dhis2/analytics#1807

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 10, 2026

🚀 Deployed on https://pr-3454.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify February 10, 2026 10:17 Inactive
@janhenrikoverland janhenrikoverland marked this pull request as ready for review February 10, 2026 10:19
@dhis2-bot dhis2-bot temporarily deployed to netlify February 10, 2026 10:20 Inactive
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have a test for this as well

@janhenrikoverland janhenrikoverland enabled auto-merge (squash) February 10, 2026 10:24
@janhenrikoverland janhenrikoverland added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Feb 11, 2026
@cypress
Copy link

cypress bot commented Feb 11, 2026

data-visualizer-app    Run #3126

Run Properties:  status check failed Failed #3126  •  git commit ebf6a98ae9 ℹ️: Merge 81f2dcbb6b3dcc5b373e07df32262e5b432f18b3 into 12cd7449a22b41e07bc56fdf47e9...
Project data-visualizer-app
Branch Review feat/use-identifiable-token-in-data-item-search
Run status status check failed Failed #3126
Run duration 10m 41s
Commit git commit ebf6a98ae9 ℹ️: Merge 81f2dcbb6b3dcc5b373e07df32262e5b432f18b3 into 12cd7449a22b41e07bc56fdf47e9...
Committer Jan Henrik Øverland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 18
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 9
Tests that passed  Passing 716
View all changes introduced in this branch ↗︎

Tests for review

Failed  totals.cy.js • 3 failed tests • e2e-chrome-parallel-41-1

View Output Video

Test Artifacts
Options - Column totals > handles empty columns when the column totals option is enabled Test Replay Screenshots Video
Options - Column totals > computes totals for boolean value types Test Replay Screenshots Video
Options - Row totals > Totals with mixed valueType/totalAggregationType > shows N/A when values along the row cannot be summed Test Replay Screenshots Video
Failed  limitValues.cy.js • 1 failed test • e2e-chrome-parallel-40-4

View Output Video

Test Artifacts
limit values > min and max value display correctly Test Replay Screenshots Video
Failed  limitValues.cy.js • 1 failed test • e2e-chrome-parallel-42-4

View Output Video

Test Artifacts
limit values > min and max value display correctly Test Replay Screenshots Video
Failed  cumulativeValues.cy.js • 2 failed tests • e2e-chrome-parallel-41-5

View Output Video

Test Artifacts
Options - Cumulative values > Applying cumulativeValues: Pivot table > correctly sort a column with cumulative values Test Replay Screenshots Video
Options - Cumulative values > Applying cumulativeValues: Pivot table > accumulates for numeric/boolean value types with totalAggregationType SUM skipping other values Test Replay Screenshots Video
Failed  totals.cy.js • 3 failed tests • e2e-chrome-parallel-40-1

View Output Video

Test Artifacts
Options - Column totals > handles empty columns when the column totals option is enabled Test Replay Screenshots Video
Options - Column totals > computes totals for boolean value types Test Replay Screenshots Video
Options - Row totals > Totals with mixed valueType/totalAggregationType > shows N/A when values along the row cannot be summed Test Replay Screenshots Video

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

Flakiness  options/cumulativeValues.cy.js • 1 flaky test • e2e-chrome-parallel-42-5

View Output Video

Test Artifacts
Options - Cumulative values > Interaction with other options (only for PT) > disables/enables a total option preserving its state Test Replay Screenshots Video
Flakiness  dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-41-4

View Output Video

Test Artifacts
Data dimension > displays Indicators correctly Test Replay Screenshots Video

@sonarqubecloud
Copy link

@janhenrikoverland janhenrikoverland merged commit 6c81d96 into master Feb 11, 2026
44 of 45 checks passed
@janhenrikoverland janhenrikoverland deleted the feat/use-identifiable-token-in-data-item-search branch February 11, 2026 14:07
dhis2-bot added a commit that referenced this pull request Feb 11, 2026
# [101.4.0](v101.3.7...v101.4.0) (2026-02-11)

### Features

* use identifiable token in data item search + ui upgrade (DHIS2-6568) (DHIS2-20698) ([#3454](#3454)) ([6c81d96](6c81d96))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants