feat: add RunInfo parameter to train/predict function signatures #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RunInfo class containing runtime information passed from CHAP to models: - prediction_length: Number of periods to predict - additional_continuous_covariates: User-specified additional covariates - future_covariate_origin: Origin/source of future covariate forecasts Update all model runner implementations (BaseModelRunner, FunctionalModelRunner, ShellModelRunner) to accept and pass run_info parameter. Update TrainRequest and PredictRequest schemas to include run_info field. This change aligns chapkit with the model contract defined in chap_core, enabling models to receive runtime configuration separately from user-defined model configuration.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add PeriodType StrEnum (any, week, month, year) to specify which time period types a model supports. MLServiceInfo now exposes this field in the /api/v1/info endpoint for CHAP to read model capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This change aligns chapkit with the model contract defined in chap_core, enabling models to receive runtime configuration separately from user-defined model configuration.