Dhall.Import refactorings
#2646
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply replace the value of `_newManager` with `return manager` for caching an already acquired `manager`.
Those settings as well as the lenses necessary to access their fields live now in an own internal module Dhall.Settings. This enables us to remove all fields from Dhall.Import.Status that were in fact duplicates of the fields of EvaluateSettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Use more lenses in
Dhall.Importand friends. My hope is that we can ultimately move to a MTL approach inDhall.Import, i.e. use(MonadIO m, MonadState Status m) => m ainstead ofStateT Status IO a.I moved
EvaluateSettingsandInputSettingsto a new (internal) moduleDhall.Settings. This enables us to have a field_evaluateSettings :: EvaluateSettingsinDhall.Import.Types.Status, since we need all the fields ofEvaluateSettingsduring import resolution anyway.A new
HasInputSettingsclass similiar toHasEvaluateSettings. The functions for the different phases in theDhallmodule now take a value ofHasInputSettings s => sinstead ofInputSettingsaccordingly.