[codex] Normalize XBRL currency unit identifiers#852
Open
gyx09212214-prog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_currency_unit()to extract ISO 4217 codes from raw XBRL currency unit identifiers.unit_refand add a normalizedcurrencyfield to facts generated byFactsView.USD,iso4217:USD,UNIT_STANDARD_HKD_*, and unknown unit formats.Why this matters
Foreign issuer filings can use raw unit identifiers like
UNIT_STANDARD_HKD_*. A normalizedcurrencycolumn makes filtering, display, and database storage reliable without losing the original XBRL unit reference.Refs #850.
Validation
python -m py_compile edgar/xbrl/currency.py edgar/xbrl/facts.py tests/xbrl/test_currency_unit_normalization.pygit diff --checkNote: full pytest was not run locally because this environment does not have
pytestinstalled.