Expose priorityClassName for alpha and zero pods#139
Open
talst wants to merge 1 commit into
Open
Conversation
- Add an optional priorityClassName to the alpha and zero StatefulSets so pods can reference an existing PriorityClass; defaults to unset - Deliberately do not expose a pod-level preemptionPolicy: Kubernetes forbids a pod whose preemptionPolicy differs from its PriorityClass, so it belongs on the PriorityClass itself (matches the Bitnami, Consul, and prometheus charts) - Add the chart's first helm-unittest suites covering the rendered field - Add a default-priority helmfile env and example values for manual live-cluster testing (v0-style, not run in CI) Co-Authored-By: Claude <noreply@anthropic.com>
talst
marked this pull request as ready for review
July 6, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129.
Problem
The alpha and zero StatefulSets have no way to reference a PriorityClass, so their pods can't be protected from preemption on contended clusters.
Solution
Expose an optional
alpha.priorityClassNameandzero.priorityClassName(default unset). Pod-levelpreemptionPolicyis intentionally not exposed: Kubernetes rejects a pod whosepreemptionPolicydiffers from its PriorityClass, so it belongs on the PriorityClass itself — matching the convention of the Bitnami, Consul, and prometheus charts.The details
Adds the chart's first
helm-unittestsuites (charts/dgraph/tests/) covering the rendered field, plus adefault-priorityhelmfile env + example values for manual live-cluster testing.🤖 Generated with Claude Code