Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed by @peterpeterparker, earlier retry delays only applied to the first outcall error instead of any failed future outcalls.
Thanks @peterpeterparker for catching this one.
Changes
delayargument inschedule_fetch_certs,Nonenow default toFETCH_CERTS_INTERVALinstead of0.schedule_fetch_certsis called withNone:FETCH_CERTS_INTERVALwith timer.60 * 2as retry delay.schedule_fetch_certsis called withSome:delaywith timer.min(FETCH_CERTS_INTERVAL, max(delay, 60) * 2)as retry delay.Tests