feat(subnet-splitting): do not validate certifications of other subnet - #10970
Draft
pierugo-dfinity wants to merge 1 commit into
Draft
feat(subnet-splitting): do not validate certifications of other subnet#10970pierugo-dfinity wants to merge 1 commit into
pierugo-dfinity wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a subnet split, nodes are still connected under the same P2P network and share the same pools of artifacts. It is only after the orchestrator detects that the split has happened (sees a
PostSplitCUP for a different subnet) that it restarts the destination replicas and then the two subnets are strictly separated.During that short window of time, the source subnet actually executes messages and it is important for the destination nodes not to create/validate any certifications/certification shares during that time.