Skip to content

fix localtime prototype#30

Merged
justwheel merged 1 commit intodevshane:masterfrom
Jan200101:PR/localtime
Apr 16, 2026
Merged

fix localtime prototype#30
justwheel merged 1 commit intodevshane:masterfrom
Jan200101:PR/localtime

Conversation

@Jan200101
Copy link
Copy Markdown
Collaborator

@Jan200101 Jan200101 commented Feb 19, 2026

Ultrix 4.2 contains a correct prototype for localtime so this should not be an issue anymore.

justwheel
justwheel approved these changes Feb 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@justwheel justwheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a C developer, but given the context from the removed-comment, this change seems sensible to me, given the newer context of Ultrix 4.2…

@Jan200101
Copy link
Copy Markdown
Collaborator Author

Jan200101 commented Feb 21, 2026

An alternative solution would be removing the prototype at all, it should be pulled in by the header even on Ultrix and I am not aware why this used to be done.

@justwheel justwheel added the bug label Feb 22, 2026
@justwheel justwheel added this to the v1.1.0 milestone Feb 22, 2026
@justwheel
Copy link
Copy Markdown
Collaborator

justwheel commented Feb 22, 2026

@jamesjer Would you be up for doing a peer review on this PR?

This was referenced Feb 22, 2026
Open
Closed
Closed
Closed
Open
@justwheel justwheel linked an issue Feb 23, 2026 that may be closed by this pull request
Create git tag/release for Zork v1.1.0 #33
Open
@justwheel justwheel mentioned this pull request Mar 5, 2026
Open
@Jan200101 @justwheel
fix localtime prototype
30a117b 
Ultrix 4.2 contains a correct prototype for localtime so this should
not be an issue anymore.
@justwheel
Copy link
Copy Markdown
Collaborator

justwheel commented Apr 16, 2026

Enough time has passed here where I feel alright merging this to master. (It might also be time to update the default branch from master to main.) I do not want these pending PRs to sit forever, and it would be nice to fix up/eliminate some of our downstream patches in the Fedora package.

I am going to merge this one as a first step. In the meantime, it would be nice if PRs #31 and #32 could be rebased on latest changes in master. 😀

Merging! 🌊

@justwheel justwheel closed this Apr 16, 2026
@justwheel justwheel reopened this Apr 16, 2026
@justwheel justwheel merged commit 30a117b into devshane:master Apr 16, 2026
This was referenced Apr 16, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justwheel justwheel justwheel approved these changes

Assignees

@devshane devshane

@justwheel justwheel

@Jan200101 Jan200101

Labels

bug

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Create git tag/release for Zork v1.1.0

3 participants

@Jan200101 @justwheel @devshane