docs: update images for device-management-toolkit #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsdmike
force-pushed
the
imageUpdates
branch
3 times, most recently
from
02020eb to
5cc5550
Compare
- fixes small spelling issues - organizes images to /diagrams and /screenshots - uses vector based graphics for diagrams device-management-toolkit/cloud-deployment#401
rsdmike
changed the title
Contributor
|
The Intel logo
|
|
|
||
| <figure class="figure-image"> | ||
| <img src="..\..\assets\images\CURLTutorial.png" alt="Figure 1: Tutorial Flow Using curl"> | ||
| <img src="..\..\assets\images\diagrams\CURLTutorial.png" alt="Figure 1: Tutorial Flow Using curl"> |
Contributor
There was a problem hiding this comment.
The referenced image includes Open Active Management Toolkit Cloud Toolkit name --- it will need updating, assuming the Illustrator file is still available.
| <figure class="figure-image"> | ||
| <img src="..\..\..\assets\images\EA_RPC_Architecture.png" width=75% alt="Figure 2: Enterprise Assistant Architecture using RPC-Go"> | ||
| <img src="..\..\..\assets\images\diagrams\EA_RPC_Architecture.png" width=75% alt="Figure 2: Enterprise Assistant Architecture using RPC-Go"> |
Contributor
There was a problem hiding this comment.
The EA images also need to be updated, as they still reference the Open AMT Cloud Toolkit Component.
| <figure class="figure-image"> | ||
| <img src="..\..\..\assets\images\EA_RPS_Architecture.png" alt="Figure 3: Enterprise Assistant Architecture using RPS"> | ||
| <img src="..\..\..\assets\images\diagrams\EA_RPS_Architecture.png" alt="Figure 3: Enterprise Assistant Architecture using RPS"> |
|
|
||
| <figure class="figure-image"> | ||
| <img src="..\..\..\assets\images\HighLevelArchitectureScaling.png" alt="Figure 1: High-level Architecture of Scaling Implementation"> | ||
| <img src="..\..\..\assets\images\diagrams\HighLevelArchitectureScaling.svg" style="height:800px;" alt="Figure 1: High-level Architecture of Scaling Implementation"> |
Contributor
There was a problem hiding this comment.
Please swap RPS and MPS in the scaling image, as CIRA and mps-router calls should point to MPS. Also, please add arrows if feasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device-management-toolkit/cloud-deployment#401
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?