Skip to content

Conversation

@nbmaiti
Copy link

@nbmaiti nbmaiti commented Dec 12, 2025

-> devcontainer go version updated to 1.25
-> devcontainer updated to include proxy settings
-> build script support proxy build

@nbmaiti nbmaiti requested review from Copilot and rsdmike December 12, 2025 10:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds proxy server support to both the build process and development container configuration, while also updating the development container's Go version from 1.x to 1.25.

  • Proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) are now configured and passed to Docker builds
  • Development container updated to Go 1.25 on Debian Trixie base image
  • Proxy settings automatically inherited from host environment in devcontainer

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
build.sh Added proxy environment variable handling and passed build args to Docker
.devcontainer/devcontainer.json Updated Go version to 1.25, added proxy environment configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.65%. Comparing base (6204935) to head (3083204).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   39.65%   39.65%           
=======================================
  Files         109      109           
  Lines       10510    10510           
=======================================
  Hits         4168     4168           
  Misses       5993     5993           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  -> devcontainer go version updated to 1.25
  -> devcontainer updated to include proxy settings
  -> build script support proxy build

Signed-off-by: Nabendu Maiti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants