-
Notifications
You must be signed in to change notification settings - Fork 11
build: proxy settings for build and devcontainer #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds proxy server support to both the build process and development container configuration, while also updating the development container's Go version from 1.x to 1.25.
- Proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) are now configured and passed to Docker builds
- Development container updated to Go 1.25 on Debian Trixie base image
- Proxy settings automatically inherited from host environment in devcontainer
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| build.sh | Added proxy environment variable handling and passed build args to Docker |
| .devcontainer/devcontainer.json | Updated Go version to 1.25, added proxy environment configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 39.65% 39.65%
=======================================
Files 109 109
Lines 10510 10510
=======================================
Hits 4168 4168
Misses 5993 5993
Partials 349 349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6a9fb89 to
69dc51e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
-> devcontainer go version updated to 1.25 -> devcontainer updated to include proxy settings -> build script support proxy build Signed-off-by: Nabendu Maiti <[email protected]>
69dc51e to
3a0a6c6
Compare
-> devcontainer go version updated to 1.25
-> devcontainer updated to include proxy settings
-> build script support proxy build