update distribution/reference import#230
update distribution/reference import#230michael-valdron merged 1 commit intodevfile:mainfrom logonoff:dist
Conversation
michael-valdron
left a comment
There was a problem hiding this comment.
@logonoff If you run make fmt_license and commit/push changes this should address the current build error.
Signed-off-by: logonoff <git@logonoff.co>
|
@logonoff Oh I see it wasn't expecting the vendor source, yeah that should work 👍 |
yeah I was wondering why a one line change added 1.4 million lines of code 😅 |
@devfile/devfile-services-team Looks like we're hitting the devfile/api#1707 issue under devfile/library as well, I'll expand that issue to include devfile/library as well. @logonoff I'll ignore this check for this PR as its unrelated and not required to merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff Do you need help merging? |
Description of Changes
Summarize the changes you made as part of this pull request.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
openshift/console#14841
Acceptance Criteria
no code changes. I am just updating an import as distribution/v3/reference does not appear to be a valid go import. this is causing some error in openshift console: