Lightmap fix for 1.21.100+

[xLynxiummcx]

Before and After

[Arctrometa]

W

[faizul726]

lynx speed run

[faizul726]

my question is that, is this actual fix or workaround.

autofixers are already having hard time finding the "workaround"

[Mrwang2408]

my question is that, is this actual fix or workaround.

autofixers are already having hard time finding the "workaround"

This is already a stable implementation as long as lazurite is 0.5.0. consider as a new version of materialbin, autofixers won't update it again.

[devendrn]

@Mrwang2408 What was the Minecraft last version without this change in lighting logic?

[Mrwang2408]

@Mrwang2408 What was the Minecraft last version without this change in lighting logic?

Minecraft Preview:
1.21.100.23 is the last version without any change (==1.21.30).
1.21.100.24 added dithering on reeds which caused some changes on a_texcoord1 input.
1.21.110.20 used new materialbin format, terrain invisible again. update lazurite 0.5.0 to fix.

Minecraft Release:
1.21.30, 1.21.94 is same as 1.21.100.23
1.21.100, 1.21.101 is same as 1.21.100.24
1.21.111 is same as 1.21.110.20

This is how the vanilla shaders be like in 1.21.100.24 essl :

v_lightmapUV = vec2(
    clamp(float(uint(floor(a_texcoord1.x * 255.0)) & 15u) * 0.0625, 0.0, 1.0),
    clamp(float((uint(floor(a_texcoord1.x * 255.0)) & 240u) >> 4u) * 0.0625, 0.0, 1.0)
);
v_dithering = float(uint(floor(a_texcoord1.y * 255.0)) & 1u);

says that multiple values were packed together in a_texcoord1.xy, we have to unpack the correct value of v_lightmapUV from a_texcoord1.x.

for a_texcoord1.y I didn't use it, because it seems just a detection of reeds. we need to do more things in fragment shaders if we really want to add the dithering effect.

commits in this pull request was optimized by me, it basically have the same function.

[devendrn]

Can someone test if this material works with Minecraft 1.21.111?
RenderChunk.zip

[faizul726]

i will test later and let you know

[faizul726]

can confirm it works

@devendrn

[devendrn]

Just a FYI for those of you who are trying to update to the above commit. You will have to delete old materials source files and run ./build.sh setup again to get new 1.21.111 lazurite material.json files.

rm ./tool/data/materials/*
./build.sh setup

Lazurite version must be 0.6.0 also.

pip install lazurite==0.6.0