chore: Update tsconfig and build script #981
Merged
+36
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
commented
Oct 27, 2025
Comment on lines
+30
to
+33
| // Build sourcemaps when not in prod | ||
| sourcemap: node_env !== "production", | ||
| // Minify only in prod | ||
| minify: node_env === "production", |
There was a problem hiding this comment.
ideally slightly easier browser debugging to have sourcemaps on and minify off in dev builds
|
I'm going to merge this for simpler debugging (with the sourcemap and minify changes) in #917 |
kylebarron
added a commit
that referenced
this pull request
Oct 28, 2025
After #981 I got an error: > ▲ [WARNING] "process.env.NODE_ENV" is defined as an identifier instead of a string (surround "development" with quotes to get a string) [suspicious-define] According to chatgpt: > The define option replaces expressions at build time, so it’s a literal text substitution. That means you must pass a valid JS expression as a string, not an identifier. Therefore we need to pass `JSON.stringify` into the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list